Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shortcuts for save and search focus #552

Merged
2 commits merged into from
Aug 5, 2022
Merged

Add shortcuts for save and search focus #552

2 commits merged into from
Aug 5, 2022

Conversation

jonandernovella
Copy link
Contributor

Related issue(s) and PR(s)

This PR closes #461

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

List of changes made

  • Two new shortcuts were added

Testing

  • Test the shortcuts when navigating over the spreadsheet

@jonandernovella jonandernovella requested a review from a team August 5, 2022 10:11
ghost
ghost approved these changes Aug 5, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. Works when focus is on a row but leaves Ctrl + S/A for normal browser use when focus i elsewhere.

@ghost ghost merged commit 40783bb into develop Aug 5, 2022
@ghost ghost deleted the dev/shortcuts branch August 5, 2022 11:44
@jonandernovella jonandernovella mentioned this pull request Aug 8, 2022
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add keyboard shortcuts for save, help, etc
1 participant
@jonandernovella