Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web performance improvements #484

Merged
merged 2 commits into from
May 23, 2022
Merged

Web performance improvements #484

merged 2 commits into from
May 23, 2022

Conversation

jonandernovella
Copy link
Contributor

@jonandernovella jonandernovella commented May 23, 2022 •
edited
Loading

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

List of changes made

  • Minified and bundled JS using snowpack's webpack plugin
  • Hopefully improved web performance

Screenshot of the fix

bild
bild

Testing

  • See how now the browser fetches bundled JS assets

Definition of Done checklist

  • I have made an effort making the commit history understandable
  • I have performed a self-review of my own code and commented any hard-to-understand areas
  • Tests and lint/format validations are passing
  • My changes generate no new warnings

@jonandernovella
Update package json files
c16670f
@jonandernovella
Add webpack plugin for snowpack
f46e921 
This will make sure that our JS is minified and bundled for production.
@jonandernovella jonandernovella requested review from jhagberg and a user May 23, 2022 09:45
kusalananda
kusalananda approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@kusalananda kusalananda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kusalananda kusalananda merged commit b70264d into develop May 23, 2022
@kusalananda kusalananda deleted the dev/web-performance branch May 23, 2022 12:04
@jonandernovella jonandernovella mentioned this pull request May 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kusalananda kusalananda kusalananda approved these changes

@jhagberg jhagberg Awaiting requested review from jhagberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonandernovella @kusalananda