-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/list dataset show more info #443
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a minor comment about the usage of single dash -
or double dash --
in the usage description.
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #443 +/- ##
===========================================
- Coverage 52.66% 39.04% -13.62%
===========================================
Files 9 11 +2
Lines 1183 1903 +720
===========================================
+ Hits 623 743 +120
- Misses 481 1048 +567
- Partials 79 112 +33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks @nanjiangshu ! Fixed by d1a2b85, please resolve when happy. |
Related issue(s) and PR(s)
This PR closes #433.
Description
sda-cli list --dataset X
will print the file ID, file size (in human or machine readable form) and file path of each file in dataset X. Also the dataset size will be printed.--bytes
is added, defaulting tofalse
. Iftrue
, file sizes are printed in byte format.How to test
From the root folder run the setup script:
(note to future self: if it does not work, remove all containers and run
docker volume rm -f $(docker volume ls -f "dangling=true")
).Then run:
And get