-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate download, replace with sda-download #427
Conversation
1151d9c
to
26f6e18
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #427 +/- ##
==========================================
- Coverage 41.24% 39.29% -1.96%
==========================================
Files 13 11 -2
Lines 2051 1891 -160
==========================================
- Hits 846 743 -103
+ Misses 1084 1036 -48
+ Partials 121 112 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
as it was depending on deprecated download
8a6cfa9
to
4faf382
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Related issue(s) and PR(s)
This PR closes #398 .
Description
download
(eg./sda-cli download <urls_file>
) is deprecated and removed./sda-cli datasetsize <urls_file>
) as it was dependent on the now deprecated function for downloading files withurls_file
.sda-download
(./sda-cli sda-download
) renamed todownload
How to test
./sda-cli download -config <configuration_file> -dataset-id <datasetID> -url <download-service-URL> <filepath>
./sda-cli download -pubkey <public-key-file> -config <configuration_file> -dataset-id <datasetID> -url <download-service-url>