Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/list datasets #415

Merged
merged 6 commits into from
Jul 11, 2024
Merged

Feature/list datasets #415

merged 6 commits into from
Jul 11, 2024

Conversation

pahatz
Copy link
Contributor

@pahatz pahatz commented Jul 10, 2024

Related issue(s) and PR(s)
This PR closes #388 .

Description
This PR extends the functionality of list to be able for the user to list the files that belong to a dataset as well as listing all the user's datasets.

How to test
Set-up the testing environment by running:

bash .github/integration/setup/setup.sh

After all services come up, test listing the user's datasets by running:

./sda-cli list -config testing/s3cmd-download.conf --datasets  -url http://localhost:8080

Test listing the files from a dataset by running:

./sda-cli list -config testing/s3cmd-download.conf -dataset https://doi.example/ty009.sfrrss/600.45asasga -url http://localhost:8080

@pahatz pahatz marked this pull request as draft July 10, 2024 15:57
@pahatz pahatz force-pushed the feature/list-datasets branch 3 times, most recently from 30aed37 to 34109ff Compare July 10, 2024 21:44
@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 20.37037% with 43 lines in your changes missing coverage. Please review.

Project coverage is 41.60%. Comparing base (461565a) to head (848d8a7).

Files Patch % Lines
list/list.go 0.00% 28 Missing and 3 partials ⚠️
sda_download/sda_download.go 50.00% 8 Missing and 3 partials ⚠️
helpers/helpers.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #415      +/-   ##
==========================================
- Coverage   42.23%   41.60%   -0.64%     
==========================================
  Files          13       13              
  Lines        1977     2024      +47     
==========================================
+ Hits          835      842       +7     
- Misses       1028     1063      +35     
- Partials      114      119       +5     
Flag Coverage Δ
unittests 41.60% <20.37%> (-0.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pahatz pahatz marked this pull request as ready for review July 10, 2024 23:40
Copy link
Contributor

@kostas-kou kostas-kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works nice

@pahatz pahatz added this pull request to the merge queue Jul 11, 2024
Merged via the queue into main with commit 93e406c Jul 11, 2024
6 checks passed
@pahatz pahatz deleted the feature/list-datasets branch July 11, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Listing dataset files and dataset filesize with sda-cli
3 participants