Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix bandpass, address scipy.integrate.trapz deprecation, address astropy security vulnerability #400

Merged

Conversation

mkelley
Copy link
Member

@mkelley mkelley commented Jul 10, 2024

  • scipy 1.6 renamed scipy.integrate.trapz to scipy.integrate.trapezoid, and scipy 1.14 has dropped scipy.integrate.trapz. Limit support to scipy>=1.6 (release Dec 2020) and use scipy.integrate.trapezoid.
  • astropy<5.3.3 has a critical security vulnerability: require astropy >= 5.3.3
  • Update min numpy version to match astropy 5.3
  • synphot 1.4 deprecated the wave_unit keyword, which causes our tests to crash when reading in the SDSS filter transmission files: add TUNIT1="ANGSTROM" to the filter transmission FITS file headers and only use wave_unit when reading in the PanSTARRS filter transmission files.
  • Testing with pyoorb and numpy=2 causes some tests to fail. I think this is due to a difference in the ABI versions. Limit continuous integration testing with pyoorb to numpy<2.

addresses #397

mkelley added 6 commits July 10, 2024 13:06
…ons.

scipy 1.6 renamed scipy.integrate.trapz to scipy.integrate.trapezoid; scipy 1.14 dropped scipy.integrate.trapz

astropy<5.3.3 has a critical security vulnerability.
@pep8speaks
Copy link

pep8speaks commented Jul 10, 2024

Hello @mkelley! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 27:80: E501 line too long (87 > 79 characters)
Line 38:80: E501 line too long (88 > 79 characters)
Line 193:80: E501 line too long (81 > 79 characters)

Comment last updated at 2024-07-11 11:20:32 UTC

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.40%. Comparing base (1315915) to head (26819aa).
Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #400      +/-   ##
==========================================
- Coverage   77.52%   77.40%   -0.12%     
==========================================
  Files          81       79       -2     
  Lines        7096     7060      -36     
==========================================
- Hits         5501     5465      -36     
  Misses       1595     1595              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkelley mkelley requested a review from hhsieh00 July 11, 2024 11:01
@mkelley
Copy link
Member Author

mkelley commented Jul 11, 2024

I think the failed code coverage check can be ignored. I removed a lot of lines from the documentation that were for astropy < 5.3, so the total number of lines covered by the tests has gone down.

Copy link
Collaborator

@hhsieh00 hhsieh00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mkelley mkelley merged commit fa1c818 into NASA-Planetary-Science:main Jul 19, 2024
8 of 9 checks passed
@mkelley mkelley deleted the bugfix-and-package-versions-2024.07 branch July 19, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants