-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix bandpass, address scipy.integrate.trapz deprecation, address astropy security vulnerability #400
Bugfix bandpass, address scipy.integrate.trapz deprecation, address astropy security vulnerability #400
Conversation
…ons. scipy 1.6 renamed scipy.integrate.trapz to scipy.integrate.trapezoid; scipy 1.14 dropped scipy.integrate.trapz astropy<5.3.3 has a critical security vulnerability.
Hello @mkelley! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-07-11 11:20:32 UTC |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #400 +/- ##
==========================================
- Coverage 77.52% 77.40% -0.12%
==========================================
Files 81 79 -2
Lines 7096 7060 -36
==========================================
- Hits 5501 5465 -36
Misses 1595 1595 ☔ View full report in Codecov by Sentry. |
I think the failed code coverage check can be ignored. I removed a lot of lines from the documentation that were for astropy < 5.3, so the total number of lines covered by the tests has gone down. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
scipy.integrate.trapz
toscipy.integrate.trapezoid
, and scipy 1.14 has droppedscipy.integrate.trapz
. Limit support to scipy>=1.6 (release Dec 2020) and use scipy.integrate.trapezoid.wave_unit
keyword, which causes our tests to crash when reading in the SDSS filter transmission files: add TUNIT1="ANGSTROM" to the filter transmission FITS file headers and only usewave_unit
when reading in the PanSTARRS filter transmission files.addresses #397