Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure pep8speaks to use 88 character line length #395

Merged

Conversation

mkelley
Copy link
Member

@mkelley mkelley commented Jan 26, 2024

I'm happy with black formatting, which uses an 88 character line length limit. Astropy has also moved to formatting code with black. Shall we change pep8speaks to use an 88 character limit? (see #394 for an example with 80 character line length but code formatted with black).

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.52%. Comparing base (1315915) to head (f59f7a7).
Report is 31 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #395   +/-   ##
=======================================
  Coverage   77.52%   77.52%           
=======================================
  Files          81       81           
  Lines        7096     7096           
=======================================
  Hits         5501     5501           
  Misses       1595     1595           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@mkelley mkelley requested a review from hhsieh00 January 26, 2024 20:03
@mkelley mkelley added this to the v0.5 milestone Jul 23, 2024
Copy link
Collaborator

@hhsieh00 hhsieh00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good

@mkelley mkelley merged commit 087ce1c into NASA-Planetary-Science:main Aug 20, 2024
9 checks passed
@mkelley mkelley deleted the pep8speaks-options-2024.01 branch August 20, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants