Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CALSPEC model solar spectrum #371

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

mkelley
Copy link
Member

@mkelley mkelley commented May 2, 2023

Adding support for a R=5000 model solar spectrum from STScI's CALSPEC database.

@mkelley
Copy link
Member Author

mkelley commented May 2, 2023

Requires #370 .

@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #371 (4ba3da1) into main (8950548) will decrease coverage by 0.04%.
The diff coverage is 77.50%.

@@            Coverage Diff             @@
##             main     #371      +/-   ##
==========================================
- Coverage   76.10%   76.06%   -0.04%     
==========================================
  Files          78       78              
  Lines        6921     6928       +7     
==========================================
+ Hits         5267     5270       +3     
- Misses       1654     1658       +4     
Impacted Files Coverage Δ
sbpy/calib/tests/test_sun.py 87.03% <76.92%> (-3.16%) ⬇️
sbpy/calib/solar_sources.py 100.00% <100.00%> (ø)

@mkelley mkelley added this to the v0.4 milestone May 24, 2023
@mkelley mkelley force-pushed the calspec-sun-202304 branch from ee37830 to 1f4d5de Compare June 7, 2023 19:43
@mkelley mkelley force-pushed the calspec-sun-202304 branch from 1f4d5de to 4ba3da1 Compare June 11, 2023 14:29
@mkelley
Copy link
Member Author

mkelley commented Jun 11, 2023

The decrease in coverage is due to adding a remote test. So, this is ready for review.

@mkelley mkelley requested a review from jianyangli June 11, 2023 14:30
Copy link
Contributor

@jianyangli jianyangli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious: In your recent few PRs, you are changing single quote (') to double quote ("). Is that something new in Python 3.10 or 3.11? I'm still using 3.8, but wondering whether I need to do the same to my personal code if I upgrade. Thanks.

@mkelley
Copy link
Member Author

mkelley commented Jun 11, 2023 via email

@mkelley mkelley merged commit 309ff50 into NASA-Planetary-Science:main Jun 12, 2023
@mkelley mkelley deleted the calspec-sun-202304 branch June 12, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants