Code reorganization for photometry submodule #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @jianyangli! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2022-07-06 18:38:58 UTC |
mkelley
approved these changes
Jul 6, 2022
sbpy/photometry/iau.py
Outdated
| from ..bib import cite | ||
|
|
||
|
|
||
| __all__ = ['HG', 'HG12BaseClass', 'HG12', 'HG1G2', 'HG12_Pen16'] |
There was a problem hiding this comment.
Is HG12BaseClass useful outside of the module?
There was a problem hiding this comment.
Right, let me remove it from exporting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate the IAU HG series functions from .core for easy code mantainance.