Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDDTool: Cleanup output log messages to use consistent formatting and remove unnecessary messages #85

Closed
jordanpadams opened this issue Oct 14, 2019 · 0 comments · Fixed by #189 or #191
Assignees

Comments

@jordanpadams
Copy link
Member

Is your feature request related to a problem? Please describe.
Current output includes a lot of messages that do not make sense to most users. These should either be refactored out entirely, or change to "debug" messages and add a debug flag to the command-line interface.

In addition, the formatting of messages varies. Consider cleaning this up so the output of log messages is consistent (and therefore more easily parseable)

Describe the solution you'd like
Remove the following from the log output:

From the top:

>>info    - Disposition File Steward/NameSpaceId:
>>info    - cart - pds
>>info    - img - disp
>>info    - img - pds
>>info    - msn - msn
>>info    - ops - pds
>>info    - pds - pds

>>info    - Found required file: /Users/jpadams/Downloads/lddtool-10.1.0/Data/dd11179.pins
>>info    - Found required file: /Users/jpadams/Downloads/lddtool-10.1.0/Data/DMDocument.pins
>>info    - Found required file: /Users/jpadams/Downloads/lddtool-10.1.0/Data/Glossary.pins
>>info    - Found required file: /Users/jpadams/Downloads/lddtool-10.1.0/Data/UpperModel.pont
>>warning - Class omitted from build - Class Identifier:0001_NASA_PDS_1.pds.Schematron_Rule
>>warning - Class omitted from build - Class Identifier:0001_NASA_PDS_1.pds.Schematron_Assert
>>info    - getMasterObjectDict - Found LDDToolSingletonClass - DMDocument.LDDToolSingletonDOMClass.title:Discipline_Area
>>info    - Found required file: /Users/jpadams/Downloads/lddtool-10.1.0/Data/UpperModel.pins

From the bottom:

>>info    - Active Namespace Ids:
>>info    - namespace_id:cart
>>info    - namespace_id:pds

>>info    - Master DOM Structures Initiated
>>info    - Master Class Map Sizes     - DOMInfoModel.masterDOMClassMap.size():405
>>info                                 - DOMInfoModel.masterDOMClassIdMap.size():405
>>info                                 - DOMInfoModel.masterDOMClassArr.size():405

>>info    - Master Property Map Sizes  - DOMInfoModel.masterDOMPropMap.size():1570
>>info                                 - DOMInfoModel.masterDOMPropIdMap.size():1553
>>info                                 - DOMInfoModel.masterDOMPropArr.size():1553

>>info    - Master Attribute Map Sizes - DOMInfoModel.masterDOMAttrMap.size():1109
>>info                                 - DOMInfoModel.masterDOMAttrIdMap.size():1109
>>info                                 - DOMInfoModel.masterDOMAttrArr.size():1109

>>info    - Master Rule Map Sizes      - DOMInfoModel.masterDOMRuleMap.size():399
>>info                                 - DOMInfoModel.masterDOMRuleIdMap.size():396
>>info                                 - DOMInfoModel.masterDOMRuleArr.size():399

>>info    - Master Data Type Sizes     - DOMInfoModel.masterDOMDataTypeMap.size():64
>>info                                 - DOMInfoModel.masterDOMDataTypeTitleMap.size():64
>>info                                 - DOMInfoModel.masterDOMDataTypeArr.size():64

>>info    - Master Unit Sizes          - DOMInfoModel.masterDOMUnitMap.size():36
>>info                                 - DOMInfoModel.masterDOMUnitTitleMap.size():36
>>info                                 - DOMInfoModel.masterDOMUnitArr.size():36

>>info    - LDDTOOL Exit
>>info    - Exit

Change the formatting of all >>info messages to reflect other INFO/ERROR format

@jordanpadams jordanpadams added enhancement New feature or request triage-needed labels Oct 14, 2019
@jordanpadams jordanpadams removed the enhancement New feature or request label Oct 14, 2019
@jordanpadams jordanpadams assigned jshughes and unassigned jshughes416 Dec 13, 2019
jshughes added a commit that referenced this issue Jun 27, 2020
…nnecessary messages

LDDTool: Cleanup output log messages to use consistent formatting and remove unnecessary messages.

Resolves #85, #86,  #87,  #178,  #176
jshughes added a commit that referenced this issue Jun 27, 2020
…nnecessary messages (#189)

LDDTool: Cleanup output log messages to use consistent formatting and remove unnecessary messages.

Resolves #85, #86,  #87,  #178,  #176
jshughes added a commit that referenced this issue Jul 11, 2020
… remove unnecessary messages - Phase 2

LDDTool: Cleanup output log messages to use consistent formatting and remove unnecessary messages. Phase 2, focused on including the LDD Parser error, warning and info messages. Also cloned code for combined LDD JSON file to LDDTool.

Resolves #85
jshughes added a commit that referenced this issue Jul 11, 2020
… remove unnecessary messages - Phase 2 (#191)

LDDTool: Cleanup output log messages to use consistent formatting and remove unnecessary messages. Phase 2, focused on including the LDD Parser error, warning and info messages. Also cloned code for combined LDD JSON file to LDDTool.

Resolves #85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants