Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LDDTool: XMLSchema Fix Nul In Import File Name #79

Closed
jshughes416 opened this issue Oct 2, 2019 · 5 comments
Closed

LDDTool: XMLSchema Fix Nul In Import File Name #79

jshughes416 opened this issue Oct 2, 2019 · 5 comments
Labels
bug Something isn't working

Comments

@jshughes416
Copy link
Contributor

LDDTool bugfix - Problem: The value for IM Version Id in the XML Schema "import" file name was being set to "null".
jshughes416 pushed a commit that referenced this issue Oct 2, 2019
@jshughes
Issue #79 LDDTool_XMLSchema_Fix_Null_In_Import
92751db 
LDDTool bugfix - Problem: The value for IM Version Id in the XML Schema "import" file name was being set to "null".
jshughes416 added a commit that referenced this issue Oct 2, 2019
@jshughes416
Merge pull request #80 from NASA-PDS-Incubator/Issue-#79-LDDTool_XMLS…
bb93cdd 
…chema_Fix_Null_In_Import

Issue #79 LDDTool_XMLSchema_Fix_Null_In_Import
@jordanpadams jordanpadams added bug Something isn't working high labels Oct 4, 2019
@jordanpadams jordanpadams changed the title LDDTool_XMLSchema_Fix_Null_In_Import_File_Name LDDTool: XMLSchema Fix Nul In Import File Name Oct 4, 2019
@jordanpadams
Copy link
Member

@jshughes416 please help out here?

@rchenatjpl
Copy link
Contributor

Yeah, I thought I could figure out where to see the effects of this fix, but nope.

@rchenatjpl
Copy link
Contributor

I still don't know how to test this, so I say it's fixed.

@jshughes
Copy link
Collaborator

jshughes commented Apr 9, 2020

This bugfix was in 1D00. The problem was that LDDTool inserted a "NULL" into the XML Schema file name even though the version id was specified in Ingest_LDD, for example, PDS4_GEOM_null_1700. I have not heard of a problem since October so the bug seems to be fixed.

@rchenatjpl
Copy link
Contributor

Great, glad to hear it. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jshughes @jordanpadams @jshughes416 @rchenatjpl