Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LDDTool 14 is not generating against past versions of the IM correctly #463

Closed
jstone-psi opened this issue Apr 13, 2022 · 3 comments · Fixed by #465
Closed

LDDTool 14 is not generating against past versions of the IM correctly #463

jstone-psi opened this issue Apr 13, 2022 · 3 comments · Fixed by #465
Assignees
@jshughes @jordanpadams
Labels
B12.1 bug Something isn't working s.high

Comments

@jstone-psi
Copy link

🐛 Describe the bug

When running lddtool 14 with the -V flag and specifiying an old version of the IM, such as 1E00 or 1F00, the tool generates hundreds of errors. This does not happen when generating without the -V flag, and does not seem to happen with past versions of LDDTool. Interestingly, the tool still generates all of the schema files that it is supposed to, however, the errors that it emits are preventing GitHub actions from running (NASA-PDS/ldd-gen-action#2)

📜 To Reproduce

Steps to reproduce the behavior:

  1. Run lddtool with the -V 1E00 flag on an ldd.
    Example: ~/bin/lddtool-14.0.0/bin/lddtool -lpJ -V 1E00 PDS4_DISP_IngestLDD.xml
  2. See error

🕵️ Expected behavior

The tool should not be generating any errors when generating its artifacts.

📚 Version of Software Used

14.0.0

🩺 Test Data / Additional context

This happens with at least the survey and disp dictionaries:
PDS4_DISP_IngestLDD.xml.txt
PDS4_SURVEY_IngestLDD.xml.txt

Here are some sample outputs:

lddtool_result_1E00.txt
lddtool_result_1F00.txt
lddtool_result_1G00.txt

🏞Screenshots

🖥 System Info

  • OS: MacOS , OpenJDK 2022-03-22
  • Version MacOS 11.6.5

🦄 Related requirements

⚙️ Engineering Details
@jstone-psi jstone-psi added bug Something isn't working needs:triage labels Apr 13, 2022
@jstone-psi jstone-psi mentioned this issue Apr 13, 2022
Closed
@jordanpadams
Copy link
Member

@jshughes can we add this as a high-priority bug fix?

@jordanpadams
Copy link
Member

@tloubrieu-jpl removing release 14.0.0 for the IM so the Github actions for LDD builds will still work

@tloubrieu-jpl
Copy link
Member

thanks @jordanpadams

@tloubrieu-jpl tloubrieu-jpl mentioned this issue Apr 14, 2022
Closed
28 tasks
jshughes pushed a commit that referenced this issue Apr 14, 2022
@jsh416
Issue #463 LDDTool 14 is not generating against past versions of the …
ce94ffc 
…IM correctly

Issue #463  LDDTool 14 is not generating against past versions of the IM correctly

The refactoring of Object Class dispositions to the Protege file is not reflected in past versions of the IM. For LDDTool runs using past versions of the IM, the Protege files is  now not referenced.

Resolves #463
@jshughes jshughes mentioned this issue Apr 14, 2022
Merged
jshughes added a commit that referenced this issue Apr 14, 2022
@jshughes @jsh416
Issue #463 LDDTool 14 is not generating against past versions of the …
8ebda02 
…IM correctly (#465)

Issue #463  LDDTool 14 is not generating against past versions of the IM correctly

The refactoring of Object Class dispositions to the Protege file is not reflected in past versions of the IM. For LDDTool runs using past versions of the IM, the Protege files is  now not referenced.

Resolves #463

Co-authored-by: John Hughes <jsh416@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jshughes jshughes

@jordanpadams jordanpadams

Labels
B12.1 bug Something isn't working s.high
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #463 LDDTool 14 is not generating against past IM versions NASA-PDS/pds4-information-model
4 participants
@jshughes @jstone-psi @jordanpadams @tloubrieu-jpl