Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LDDTool: update LDD attribute checking to only check for "type" and "_type" #230

Closed
jordanpadams opened this issue Sep 16, 2020 · 0 comments · Fixed by #231
Closed

LDDTool: update LDD attribute checking to only check for "type" and "_type" #230

jordanpadams opened this issue Sep 16, 2020 · 0 comments · Fixed by #231
Assignees
@jshughes
Labels
bug Something isn't working

Comments

@jordanpadams
Copy link
Member

Describe the bug
When attempting to generate ldd-ctli, we get this error:

>>> ERROR Attribute: <subtype> - The 'type' attribute must have at least one permissible value.

Per @lylehuber:

The ERROR attributed to “subtype” is itself an error. It is only of type “type” if it ends in “_type” (or is only “type”). Please adjust your error checker accordingly.

To Reproduce

lddtool -lp $(pwd)/PDS4_CTLI_IngestLDD.xml

CTLI LDD - https://raw.githubusercontent.com/pds-data-dictionaries/ldd-ctli/master/src/PDS4_CTLI_IngestLDD.xml
@jordanpadams jordanpadams added bug Something isn't working triage-needed labels Sep 16, 2020
jshughes added a commit that referenced this issue Sep 17, 2020
@jshughes
LDDTool: update LDD attribute checking to only check for "type" and "…
bce4818 
…_type"

LDDTool: update LDD attribute checking to only check for "type" and "_type". The ERROR attributed to “subtype” is itself an error. It is only of type “type” if it ends in “_type” (or is only “type”). A subType should not be checked.

Resolves #230
Refs CCB-204
@jshughes jshughes mentioned this issue Sep 17, 2020
Merged
jshughes added a commit that referenced this issue Sep 17, 2020
@jshughes
LDDTool: update LDD attribute checking to only check for "type" and "…
d5fb619 
…_type" (#231)

LDDTool: update LDD attribute checking to only check for "type" and "_type". The ERROR attributed to “subtype” is itself an error. It is only of type “type” if it ends in “_type” (or is only “type”). A subType should not be checked.

Resolves #230
Refs CCB-204
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jshughes jshughes

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

LDDTool: update LDD attribute - check only for "type" and "_type" NASA-PDS/pds4-information-model
2 participants
@jshughes @jordanpadams