Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disabled terraform workflow #57

Merged
merged 1 commit into from
Jul 14, 2023
Merged

disabled terraform workflow #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions .github/workflows/terraform-cicd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
name: 'Terraform-Workflow'

#Currently this workflow is disabled since resources were already deployed manually in NGAP.

on:
push:
branches:
- '**'
pull_request:
types: [opened, edited, reopened, ready_for_review, review_requested]
# push:
workflow_dispatch:

permissions:
Expand Down Expand Up @@ -50,7 +48,6 @@ jobs:

- name: Terraform Plan
id: plan
if: github.event_name == 'push' || github.event_name == 'pull_request'
env:
TF_VAR_efs_file_system_id: "${{ secrets.EFS_FILE_SYSTEM_ID }}"
TF_VAR_registry_loader_scripts_access_point_id: "${{ secrets.REGISTRY_LOADER_SCRIPTS_ACCESS_POINT_ID }}"
Expand Down
17 changes: 8 additions & 9 deletions terraform/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ module "mwaa-env" {
airflow_execution_role = var.airflow_execution_role
}


# The following modules are specific to PDS Registry and are under development. These modules are currently
# capable of successfully deploying some ECS tasks related with PDS Registry. However, these modules
# are currently disabled to keep the PDS Nucleus Baseline System clean and to avoid confusions.
Expand All @@ -18,12 +17,12 @@ module "mwaa-env" {
# source = "./terraform-modules/efs"
# }

module "ecs" {
source = "./terraform-modules/ecs"
# module "ecs" {
Copy link
Member

@nutjob4life nutjob4life Jul 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whenever something is commented-out, I like to see a one-line explanation as to why. It causes less worry in the future!

If it's truly not needed, delete it with prejudice 😈

# source = "./terraform-modules/ecs"

efs_file_system_id = var.efs_file_system_id
registry_loader_scripts_access_point_id = var.registry_loader_scripts_access_point_id
registry_loader_default_configs_access_point_id = var.registry_loader_default_configs_access_point_id
task_role_arn = var.task_role_arn
execution_role_arn = var.execution_role_arn
}
# efs_file_system_id = var.efs_file_system_id
# registry_loader_scripts_access_point_id = var.registry_loader_scripts_access_point_id
# registry_loader_default_configs_access_point_id = var.registry_loader_default_configs_access_point_id
# task_role_arn = var.task_role_arn
# execution_role_arn = var.execution_role_arn
# }
1 change: 1 addition & 0 deletions terraform/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,3 +63,4 @@ variable "execution_role_arn" {
description = "Airflow Execution Role ARN"
sensitive = true
}