Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Update datamodels #21

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

anisbhsl
Copy link
Collaborator

Major Changes:

Added SinequaBaseModel as abstract class. All other model classes now inherit this abstract class and have to implement generate_payload(..) method.

Minor Changes

  1. Added dataclasses
  2. Added a test to check queryparams payload generation
  3. Code fixes

@anisbhsl anisbhsl requested a review from NISH1001 October 13, 2023 20:56
pynequa/models.py Outdated Show resolved Hide resolved
pynequa/models.py Outdated Show resolved Hide resolved
pynequa/models.py Outdated Show resolved Hide resolved
@anisbhsl anisbhsl linked an issue Oct 16, 2023 that may be closed by this pull request
@NISH1001
Copy link
Collaborator

LGTM

@anisbhsl anisbhsl merged commit ca7da69 into develop Oct 18, 2023
1 check passed
@anisbhsl anisbhsl deleted the feature/create-abstract-class-for-models branch October 18, 2023 18:12
anisbhsl added a commit that referenced this pull request Oct 24, 2023
* Add documentation for pynequa  (#7)

* added readme and license

* added readthedocs config

* added conf.py

update conf

update conf

removed theme

reset

* fix sphinx docs

* fix typo

* added in gitignore

* Feature: Add github action workflows and tests (#8)

* added build check action

* minor changes

* changes in markdowns

* build on push only

* added mock and actual api unit tests

* update install command for pypi

* add release version

* added usage example and minor fixes (#10)

* added engine.sql method (#13)

* Add classmethod for initializing Sinequa class (#18)

* added classmethod for initializing Sinequa class

* updated docs

* don't send empty params in payload

* don't send empty params in payload (#20)

* fix error with payload generation

* Feature: Update datamodels  (#21)

* updated datamodels to use dataclass

* resolved comments

* updated metadata in docs
@anisbhsl anisbhsl self-assigned this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dataclasses for models
2 participants