Skip to content

Commit

Permalink
Upgrade tooling to fix broken build (#300)
Browse files Browse the repository at this point in the history
- Have tox install current LTS release of nodejs
- Have tox install latest v2.x release of CDK CLI
- Update pip editable install to work with pip 25+

The last point addresses the following warning when running tox:

> DEPRECATION: Legacy editable install of hls_lambda_layer==0.0.0 from
> file:///Users/chuck/src/NASA-IMPACT/hls-orchestration/layers/hls_lambda_layer/python
> (setup.py develop) is deprecated. pip 25.0 will enforce this behaviour
> change. A possible replacement is to add a pyproject.toml or enable
> --use-pep517, and use setuptools >= 64. If the resulting installation
> is not behaving as expected, try using --config-settings editable_mode=compat.
> Please consult the setuptools documentation for more information.
> Discussion can be found at pypa/pip#11457
  • Loading branch information
chuckwondo authored Oct 9, 2024
1 parent 0dbfa2f commit 843a044
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
4 changes: 3 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@
"constructs>=10.0.0",
]

install_requires: list[str] = []
install_requires: list[str] = [
"setuptools>=64",
]

extras_require_test = [
*aws_cdk_extras,
Expand Down
6 changes: 3 additions & 3 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ extras = test
envdir = toxenv
passenv = AWS_DEFAULT_REGION
commands =
pip install -e ./layers/hls_lambda_layer/python
pip install --use-pep517 -e ./layers/hls_lambda_layer/python
python -m pytest --cov=lambda_functions --ignore=node_modules --ignore=cdk.out
flake8

Expand All @@ -17,8 +17,8 @@ passenv =
HLS_*
AWS_*
commands =
nodeenv --node=20.17.0 --python-virtualenv
npm install -g aws-cdk@v2.155.0
nodeenv --node=lts --python-virtualenv
npm install -g aws-cdk@v2.*
cdk --version

[testenv:dev]
Expand Down

0 comments on commit 843a044

Please sign in to comment.