-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output non-matching eDSL objects to String #746
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automatically approved due to detection of the following labels: hotfix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automatically approved due to detection of the following labels: hotfix
What would I do to test this manually? |
|
ba1b7bc
to
be82eea
Compare
Address the problem of converting eDSL from SeqJSON, wherein, if the eDSL fails to recognize the SeqJSON object, it should populate the sequence with the placeholder [object]
be82eea
to
3c94cf8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally. LGTM! Thanks for the quick fix.
Description
Address the problem of converting eDSL from SeqJSON, wherein, if the eDSL fails to recognize the SeqJSON object, it should populate the sequence with the placeholder [object]
In this example since
Activate
andLoad
are not a definedStep
in the eDSL so it can't convert it to eDSL and outputs step. Now it will just preserve the SeqJSON by fully outputting the object.Verification
e2e test work as well as my manual test