Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output non-matching eDSL objects to String #746

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

goetzrrGit
Copy link
Contributor

  • Tickets addressed: AERIE-000
  • Review: By commit
  • Merge strategy: Merge (no squash)

Description

Address the problem of converting eDSL from SeqJSON, wherein, if the eDSL fails to recognize the SeqJSON object, it should populate the sequence with the placeholder [object]

In this example since Activate and Load are not a defined Step in the eDSL so it can't convert it to eDSL and outputs step. Now it will just preserve the SeqJSON by fully outputting the object.

export default () =>
  Sequence.new({
    seqId: '',
    metadata: {},
    steps: [
      [Object],
      C.BAKE_BREAD
      ]
  });

Verification

e2e test work as well as my manual test

@goetzrrGit goetzrrGit added hotfix sequencing Anything related to the sequencing domain labels Mar 16, 2023
@goetzrrGit goetzrrGit requested a review from a team as a code owner March 16, 2023 22:28
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved due to detection of the following labels: hotfix

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved due to detection of the following labels: hotfix

@Mythicaeda
Copy link
Contributor

What would I do to test this manually?

@goetzrrGit
Copy link
Contributor Author

@Mythicaeda

  1. Download this json file (https://github.com/NASA-AMMOS/seq-json-schema/blob/develop/test/valid-seq-json/all-possible-fields.seq.json)
  2. navigate to Sequence Editor in AERIE
  3. Hit the browser button for Create Sequence from Seq JSON (optional)
  4. upload the json file you download
  5. You shouldn't see [object] for all the step fields

@goetzrrGit goetzrrGit force-pushed the hotfix-object-to-string-edsl branch from ba1b7bc to be82eea Compare March 16, 2023 23:10
@camargo camargo changed the title [HOTFIX] Output non-matching eDSL objects to String Output non-matching eDSL objects to String Mar 16, 2023
@camargo camargo added the fix A bug fix label Mar 16, 2023
@camargo camargo added this to the FY23 Q2 - Ad Hoc Improvements milestone Mar 16, 2023
Address the problem of converting eDSL from SeqJSON, wherein, if the eDSL fails to recognize the SeqJSON object, it should populate the sequence with the placeholder [object]
@goetzrrGit goetzrrGit force-pushed the hotfix-object-to-string-edsl branch from be82eea to 3c94cf8 Compare March 16, 2023 23:18
@goetzrrGit goetzrrGit temporarily deployed to e2e-test March 16, 2023 23:18 — with GitHub Actions Inactive
Copy link
Member

@camargo camargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. LGTM! Thanks for the quick fix.

@goetzrrGit goetzrrGit merged commit b325664 into develop Mar 16, 2023
@goetzrrGit goetzrrGit deleted the hotfix-object-to-string-edsl branch March 16, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A bug fix sequencing Anything related to the sequencing domain
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants