Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SchedulingActivityDirective.instantiateArguments() #671

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

Mythicaeda
Copy link
Contributor

@Mythicaeda Mythicaeda commented Feb 14, 2023

  • Tickets addressed: Hotfix
  • Review: By commit
  • Merge strategy: Merge (no squash)

Description

Changed a line SchedulingActivityDirective.instantiateArguments() so that it evaluates the interval at a singleton bounds rather than for Interval.FOREVER, as StructExpressionAt and ListExpressionAt expect singleton bounds when they are evaluated.

Verification

Added a test to check that the following types of arguments are now parsed correctly:

  • StructExpressionAt
  • ListExpressionAt
  • ValueAt
  • DiscreteValue
  • RealValue

@Mythicaeda Mythicaeda added bug Something isn't working fix A bug fix labels Feb 14, 2023
@Mythicaeda Mythicaeda added this to the 1.1.0 - Bug Fixes milestone Feb 14, 2023
@Mythicaeda Mythicaeda requested a review from a team as a code owner February 14, 2023 22:34
@Mythicaeda Mythicaeda requested a review from skovati February 14, 2023 22:34
@Mythicaeda Mythicaeda temporarily deployed to e2e-test February 14, 2023 22:34 — with GitHub Actions Inactive
@Mythicaeda Mythicaeda merged commit 17c705f into develop Feb 14, 2023
@Mythicaeda Mythicaeda deleted the fix/fix-546 branch February 14, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix A bug fix
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants