Add JSON Spec to sequencing server #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goetzrrGit
changed the title
camargo
changed the title
camargo
added
refactor
camargo
reviewed
Jan 24, 2023
goetzrrGit
force-pushed
the
feature/609--Add_JSON_spec_to_sequencing_server
branch
from
8f89db5 to
7a1396e
Compare
goetzrrGit
force-pushed
the
feature/609--Add_JSON_spec_to_sequencing_server
branch
from
7a1396e to
09375a1
Compare
camargo
requested review from
cohansen and
camargo
and removed request for
mattdailis and
JoelCourtney
goetzrrGit
force-pushed
the
feature/609--Add_JSON_spec_to_sequencing_server
branch
from
09375a1 to
23966f8
Compare
goetzrrGit
force-pushed
the
feature/609--Add_JSON_spec_to_sequencing_server
branch
from
23966f8 to
bce4b9c
Compare
|
@cohansen Yeah, I think merge your PR first and I will rebase this one. |
This is to avoid the namespace collision with the JSON Spec.
Now the commandLib has both the spec and edsl.
goetzrrGit
force-pushed
the
feature/609--Add_JSON_spec_to_sequencing_server
branch
from
bce4b9c to
f625d8b
Compare
goetzrrGit
deleted the
feature/609--Add_JSON_spec_to_sequencing_server
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The overall goal is to incorporate the JSON spec into the Aerie Repo and give eDSL access to the full JSON Spec while wrapping the current EDSL into the 4 command types. The goal is to clean up the code and merge more of the spec and EDSL API together to create a tighter coupling, and to look at how to write custom eDSL to make the process easier.
This is the first part of the development process, which will be to add the JSON spec to the Aerie Repo and combine it with the EDSL.
Verification
I ran through the e2e tests without any issues.
Documentation
None
Future work
Rework the Sequence eDSL class with this new spec file.