Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scheduling goal examples to use Temporal.Duration #483

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

mattdailis
Copy link
Collaborator

  • Tickets addressed: N/A
  • Review: By commit
  • Merge strategy: Merge (no squash)

Description

This PR updates the examples in the generated scheduling edsl docs to use Temporal.Duration instead of integer microseconds.

Verification

I ran cd docs && ./buildExternalDocs.bash, and checked that it rendered correctly - let me know if there's something else I should check.

Documentation

See description.

Future work

None

@mattdailis mattdailis added the documentation Improvements or additions to documentation label Nov 15, 2022
@mattdailis mattdailis requested a review from a team as a code owner November 15, 2022 14:48
@mattdailis mattdailis self-assigned this Nov 15, 2022
@mattdailis mattdailis requested a review from camargo November 15, 2022 14:48
@mattdailis mattdailis temporarily deployed to e2e-test November 15, 2022 14:49 Inactive
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved due to detection of the following labels: documentation

@mattdailis mattdailis force-pushed the docs/scheduling-temporal-duration-examples branch from 683acab to 805c2d6 Compare November 15, 2022 18:10
@mattdailis mattdailis temporarily deployed to e2e-test November 15, 2022 18:10 Inactive
@camargo camargo merged commit 5d7f66c into develop Nov 15, 2022
@camargo camargo deleted the docs/scheduling-temporal-duration-examples branch November 15, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants