[AERIE-2198] Assign Gaps #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelCourtney
force-pushed
the
feat/AERIE-2198--assign-gaps
branch
from
ba7e77f to
c3c5e0a
Compare
pcrosemurgy
reviewed
Nov 10, 2022
constraints/src/main/java/gov/nasa/jpl/aerie/constraints/tree/AssignGaps.java
Outdated
Show resolved
Hide resolved
pcrosemurgy
reviewed
Nov 10, 2022
constraints/src/main/java/gov/nasa/jpl/aerie/constraints/tree/WindowsValue.java
Outdated
Show resolved
Hide resolved
JoelCourtney
force-pushed
the
feat/AERIE-2198--assign-gaps
branch
from
c3c5e0a to
63c153f
Compare
pcrosemurgy
approved these changes
Nov 10, 2022
JoelCourtney
force-pushed
the
feat/AERIE-2198--assign-gaps
branch
from
63c153f to
3fc6319
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the
assignGapsoperation to theWindows,Real, andDiscreteclasses of the eDSL. To do this, I also had to implement aWindowsValuenode similar toRealValueandDiscreteValue, which takes a boolean and produces a constant Windows.On the java side I also made
WindowsimplementProfile<Windows>so that I could addassignGapstoProfile. This means that I had to implementequal,notEqual, andchangePointsfor Windows. These could be exposed in the eDSL in the future, but aren't in this PR.Verification
I added the usual parsing, evaluation, and compilation tests for
AssignGapsandWindowsValue.Documentation
Doc comments are included on the new TS functions. The tutorial docs are already written assuming this change is included in 1.0
Future work