[FIX] Load scheduling DSL TypeScript libraries in scheduler-server

[pcrosemurgy]

• Tickets addressed: None
• Review: By commit
• Merge strategy: Merge (no squash)

Description

Since splitting scheduler-server into scheduler-worker – and thereby relocating the scheduling DSL Node project – the scheduler server has not had access to static DSL libraries. This PR loads scheduling DSL TypeScript libraries from the scheduler server JAR instead of requiring Docker to be configured to copy in the directory and set an environment variable.

Verification

• Unit test added to test loading .ts files from the scheduler-server JAR.
• Manually tested end-to-end.
• Automated end-to-end tests.

Documentation

None.

Future work

None.

[JoelCourtney]

Manually tested end-to-end.

Can you automate it instead just for good measure? We already have a set of scheduler e2e tests that should do the busy work of uploading a model and creating goals.

[pcrosemurgy]

@JoelCourtney Sure! I'll give it a shot.

[camargo]

Tested this branch against the UI e2e tests as well and all pass!

[pcrosemurgy]

Not sure why this is failing:

1) src/tests/scheduler.test.ts:35:3 › Scheduling › Get scheduling DSL TypeScript =================

    ReferenceError: mission_model_id is not defined

      34 |
      35 |   test('Get scheduling DSL TypeScript', async ({ request }) => {
    > 36 |     typescriptFiles = await req.getSchedulingDslTypeScript(request, mission_model_id);
         |                                 ^
      37 |     expect(typescriptFiles).toBeDefined();
      38 |   });
      39 |

        at Object.getSchedulingDslTypeScript (file:///home/runner/work/***/***/e2e-tests/src/utilities/requests.ts:[176](https://github.com/NASA-AMMOS/aerie/actions/runs/3414650049/jobs/5682881013#step:13:177):97)
        at file:///home/runner/work/***/***/e2e-tests/src/tests/scheduler.test.ts:36:33

The test('Get scheduling DSL TypeScript', ...) comes right after test('Upload jar and create mission model', ...) which sets mission_model_id.

Edit: I think I've fixed this. The above error is strange as it makes it look like mission_model_id within the context of await req.getSchedulingDslTypeScript(request, mission_model_id); is undefined. However, it was actually undefined within utilities/requests.ts. The trace preview here is misleading IMO.

[pcrosemurgy]

Manually tested end-to-end.

Can you automate it instead just for good measure? We already have a set of scheduler e2e tests that should do the busy work of uploading a model and creating goals.

@JoelCourtney Done :)

[mattdailis]

Did a quick manual check locally - intellisense is working in the scheduling goal editor again 🙏 Thanks for the quick turnaround, Paul 🎉