[FIX] Use property for publishing version string #416
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The previous solution using
rootProject.ext.versionForPublishing
failed when building Aerie locally from a separate Gradle project, likely due torootProject
taking on a different value/meaning in that context.Using a global property here we're able to specify the publishing version in the top-level build and guarantee that any uses of it are localized to subprojects of our top-level build.
Verification
gradle assemble -PuseLocalAerie=true -PlocalAeriePath=../../aerie
from a clonedaerie-simple-mission-model
compiles the mission model without issues.Documentation
None.
Future work
We'll want to apply this patch to the https://github.jpl.nasa.gov/Aerie/aerie-simple-mission-model repo.: