Rename InvalidArgumentsException -> InstantiationException
#371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcrosemurgy
requested review from
mattdailis
and removed request for
goetzrrGit
pcrosemurgy
force-pushed
the
fix/rename-invalid-arguments-exception
branch
from
692d807 to
80bb5fa
Compare
pcrosemurgy
force-pushed
the
fix/rename-invalid-arguments-exception
branch
from
80bb5fa to
98f70e7
Compare
pcrosemurgy
force-pushed
the
fix/rename-invalid-arguments-exception
branch
from
47c8ca4 to
ac4f724
Compare
|
I feel like "erroneous" is still roughly synonymous; I could still see confusion arising here. How about |
|
Or, since the exception occurs directly on the |
Update aerielander.jar
pcrosemurgy
force-pushed
the
fix/rename-invalid-arguments-exception
branch
from
ac4f724 to
6e382bf
Compare
|
|
pcrosemurgy
changed the title
InvalidArgumentsException -> ErroneousArgumentsExceptionInvalidArgumentsException -> InstantiationException
mattdailis
approved these changes
Oct 12, 2022
camargo
added a commit
to NASA-AMMOS/aerie-ui
that referenced
this pull request
Oct 12, 2022
- Required after NASA-AMMOS/aerie#371
camargo
added a commit
to NASA-AMMOS/aerie-ui
that referenced
this pull request
Oct 12, 2022
- Required after NASA-AMMOS/aerie#371
JosephVolosin
pushed a commit
to NASA-AMMOS/aerie-ui
that referenced
this pull request
Aug 20, 2024
- Required after NASA-AMMOS/aerie#371
JosephVolosin
pushed a commit
to NASA-AMMOS/aerie-ui
that referenced
this pull request
Oct 21, 2024
- Required after NASA-AMMOS/aerie#371
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note: this PR's renaming changes the sig. of a mission model interface, therefore mission models must be updated.
This PR renames
InvalidArgumentsException->InstantiationExceptionto minimize confusion between arguments being "invalid" (unconstructable, missing, or extraneous) and our "validation" endpoint responses indicating arguments that are "invalid" (failed an@Validationcheck).Verification
All tests passing.
Documentation
Related docs updated.
Future work
None.