Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: increase command expansion server body parser limit #323

Merged
merged 1 commit into from
Sep 13, 2022
Merged

feat: increase command expansion server body parser limit #323

merged 1 commit into from
Sep 13, 2022

Conversation

camargo
Copy link
Member

@camargo camargo commented Sep 13, 2022

Description

  • When trying to upload a 27mb command dictionary I got a request entity too large error
  • This commit just allows for much larger command dictionaries by increasing the max body size limit for the upload server

@camargo
feat: increase command expansion server body parser limit
eef2d49 
- Allows for much larger command dictionaries
@camargo camargo requested a review from a team as a code owner September 13, 2022 16:05
@camargo camargo temporarily deployed to e2e-test September 13, 2022 16:06 Inactive
@camargo camargo requested a review from dyst5422 September 13, 2022 16:06
mattdailis
mattdailis approved these changes Sep 13, 2022
View reviewed changes
Copy link
Collaborator

@mattdailis mattdailis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me! I left one question just for my own education.

command-expansion-server/src/app.ts Show resolved Hide resolved
@camargo camargo merged commit 9a2d295 into develop Sep 13, 2022
@camargo camargo deleted the feat/increase-expansion-server-body-limit branch September 13, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattdailis mattdailis mattdailis approved these changes

@dyst5422 dyst5422 dyst5422 approved these changes

@patkenneally patkenneally Awaiting requested review from patkenneally patkenneally is a code owner automatically assigned from NASA-AMMOS/aerie-backend

Assignees

@camargo camargo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@camargo @mattdailis @dyst5422