-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AERIE-1982] feat: add user sequence table #304
Conversation
command-expansion-server/sql/commanding/tables/user_sequence.sql
Outdated
Show resolved
Hide resolved
deployment/hasura/metadata/databases/AerieCommanding/tables/public_user_sequence.yaml
Show resolved
Hide resolved
I was thinking about this for a couple of minutes and I realized we never talked about user-defined sequences with respect to their sequence ID. On the command expansion side, we make those unique but on the user side, they can create multiple sequences for a sequence ID with no sequence ID checking. Use Case 1: Create a new sequence with seqID A, save - no issue Use Case 2: Create a new sequence with seqID A, save - no issue Use Case 3: Create a new sequence with seqID A, save - no issue This can get more complicated as there can be different states a sequence can be in ( Draft, Accepted, Rejected, etc.) I am not saying we should address this in this ticket but something we should have a meeting about in the future. |
Sequence IDs are very specifically NOT something we are managing. That is on the missions to determine. The unique ID for sequences we have are disconnected from the seqid and in fact the seqid isn't necessarily part of what is tracked by AERIE at all. I would think the workflow would haver the seqid somewhere in the |
You are right, I forgot we are not managing sequence ID and that a mission should do that. :P Let me close that can of worms and bury it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing much to add besides creating a ticket from Dylan's comment.
command-expansion-server/sql/commanding/tables/user_sequence.sql
Outdated
Show resolved
Hide resolved
deployment/hasura/metadata/databases/AerieCommanding/tables/public_user_sequence.yaml
Show resolved
Hide resolved
5307326
to
b29b755
Compare
b29b755
to
ffef539
Compare
- For use with user-defined sequences in the UI
ffef539
to
785d76b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!!!
Description
user_sequence
table for storing user-defined sequences for 0.13.0Verification
Test the
user_sequence
table is added to the commanding databaseFuture work
Possible renaming:
aerie_commanding
database toaerie_sequencing
sequence
table toexpansion_sequence