Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AERIE-1982] feat: add user sequence table #304

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Conversation

camargo
Copy link
Member

@camargo camargo commented Aug 30, 2022

  • Tickets addressed: AERIE-1982
  • Review: By commit
  • Merge strategy: Merge (no squash)

Description

  • Add first-draft of user_sequence table for storing user-defined sequences for 0.13.0

Verification

Test the user_sequence table is added to the commanding database

Future work

Possible renaming:

  • aerie_commanding database to aerie_sequencing
  • sequence table to expansion_sequence

@goetzrrGit
Copy link
Contributor

I was thinking about this for a couple of minutes and I realized we never talked about user-defined sequences with respect to their sequence ID. On the command expansion side, we make those unique but on the user side, they can create multiple sequences for a sequence ID with no sequence ID checking.

Use Case 1:

Create a new sequence with seqID A, save - no issue
I want to update the sequence, save - no issue

Use Case 2:

Create a new sequence with seqID A, save - no issue
I create a new sequence with seqID B, save - no issue

Use Case 3:

Create a new sequence with seqID A, save - no issue
I create a brand new sequence with seqID A, save - Problem: two sequences with the same seqID

This can get more complicated as there can be different states a sequence can be in ( Draft, Accepted, Rejected, etc.)

I am not saying we should address this in this ticket but something we should have a meeting about in the future.

@dyst5422
Copy link
Contributor

I was thinking about this for a couple of minutes and I realized we never talked about user-defined sequences with respect to their sequence ID. On the command expansion side, we make those unique but on the user side, they can create multiple sequences for a sequence ID with no sequence ID checking.

Use Case 1:

Create a new sequence with seqID A, save - no issue I want to update the sequence, save - no issue

Use Case 2:

Create a new sequence with seqID A, save - no issue I create a new sequence with seqID B, save - no issue

Use Case 3:

Create a new sequence with seqID A, save - no issue I create a brand new sequence with seqID A, save - Problem: two sequences with the same seqID

This can get more complicated as there can be different states a sequence can be in ( Draft, Accepted, Rejected, etc.)

I am not saying we should address this in this ticket but something we should have a meeting about in the future.

Sequence IDs are very specifically NOT something we are managing. That is on the missions to determine. The unique ID for sequences we have are disconnected from the seqid and in fact the seqid isn't necessarily part of what is tracked by AERIE at all. I would think the workflow would haver the seqid somewhere in the name field, but ultimately, the seqid is determined by the seqid property on the sequence object in the body of the sequence file.

@goetzrrGit
Copy link
Contributor

I was thinking about this for a couple of minutes and I realized we never talked about user-defined sequences with respect to their sequence ID. On the command expansion side, we make those unique but on the user side, they can create multiple sequences for a sequence ID with no sequence ID checking.
Use Case 1:
Create a new sequence with seqID A, save - no issue I want to update the sequence, save - no issue
Use Case 2:
Create a new sequence with seqID A, save - no issue I create a new sequence with seqID B, save - no issue
Use Case 3:
Create a new sequence with seqID A, save - no issue I create a brand new sequence with seqID A, save - Problem: two sequences with the same seqID
This can get more complicated as there can be different states a sequence can be in ( Draft, Accepted, Rejected, etc.)
I am not saying we should address this in this ticket but something we should have a meeting about in the future.

Sequence IDs are very specifically NOT something we are managing. That is on the missions to determine. The unique ID for sequences we have are disconnected from the seqid and in fact the seqid isn't necessarily part of what is tracked by AERIE at all. I would think the workflow would haver the seqid somewhere in the name field, but ultimately, the seqid is determined by the seqid property on the sequence object in the body of the sequence file.

You are right, I forgot we are not managing sequence ID and that a mission should do that. :P Let me close that can of worms and bury it.

Copy link
Contributor

@goetzrrGit goetzrrGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing much to add besides creating a ticket from Dylan's comment.

@camargo camargo force-pushed the feat/user-sequence branch from 5307326 to b29b755 Compare August 30, 2022 23:19
@camargo camargo requested a review from Mythicaeda as a code owner August 30, 2022 23:19
@camargo camargo temporarily deployed to e2e-test August 30, 2022 23:19 Inactive
@camargo camargo force-pushed the feat/user-sequence branch from b29b755 to ffef539 Compare August 30, 2022 23:56
@camargo camargo temporarily deployed to e2e-test August 30, 2022 23:56 Inactive
- For use with user-defined sequences in the UI
@camargo camargo force-pushed the feat/user-sequence branch from ffef539 to 785d76b Compare August 31, 2022 00:25
@camargo camargo temporarily deployed to e2e-test August 31, 2022 00:25 Inactive
@camargo camargo changed the title feat: add user sequence table [AERIE-1982] feat: add user sequence table Aug 31, 2022
@dyst5422 dyst5422 self-requested a review August 31, 2022 15:20
Copy link
Contributor

@goetzrrGit goetzrrGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!!!

@camargo camargo merged commit f78ae0d into develop Aug 31, 2022
@camargo camargo deleted the feat/user-sequence branch August 31, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants