[HOTFIX] Scanning action detecting vulnerabilities shouldn't fail publish pipeline #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done so that last minute dependency vulnerabilities don't interfere with publishing. Scan results can still be viewed and acted upon with a separate PR
skovati
requested review from
patkenneally,
pcrosemurgy,
mattdailis,
goetzrrGit,
dyst5422,
adrienmaillard,
camargo and
JoelCourtney
as code owners
camargo
approved these changes
Aug 24, 2022
patkenneally
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done so that last minute dependency vulnerabilities don't
interfere with publishing. Scan results can (and should) still be viewed and acted
upon with a separate PR.
Description
As it currently stands, last minute transitive dependencies with vulnerabilities can fail our publish pipeline, and require dependency updates right before a point release.
This PR makes
trivyexit with code 0 even if vulns are detected, so that we can continue publishing and fix dependency vulnerabilities at a more convenient time.Future work
AERIE-2042 will upload these scan results in the SARIF format as an artifact so we see failed scans in the Github Security page for the repo