[HOTFIX] Fix bad npm registry #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyst5422
requested review from
patkenneally,
pcrosemurgy,
mattdailis,
goetzrrGit,
adrienmaillard,
camargo and
JoelCourtney
as code owners
goetzrrGit
reviewed
Aug 18, 2022
🤦 |
dyst5422
force-pushed
the
hotfix/bad-npm-source
branch
from
84c59c2 to
daf10f4
Compare
dyst5422
force-pushed
the
hotfix/bad-npm-source
branch
from
daf10f4 to
710ee0a
Compare
goetzrrGit
reviewed
Aug 18, 2022
There was an issue in 0.53.1 and 0.54.0, so we'll lock it here for now
|
This has turned into a dependency nightmare. I think I've got it right this time. |
Great question. I have no idea. It's clearly right here https://github.com/NASA-AMMOS/aerie/blob/hotfix/bad-npm-source/command-expansion-server/package-lock.json#L1046 Perhaps I had already installed the 0.3.1 locally on a different day when my registry was correctly set and so the package-lock didn't change. |
|
@goetzrrGit finally got it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When I updated the user code runner, my npm registry was set to JPL artifactory, so that got encoded into the package-lock files. This fixes that blunder.
Also locks version for typescript-json-schema to work around a dependency error with the 0.53.1 version
Verification
Documentation
Future work