[AERIE-1941] Rename activity table to activity_directive #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyst5422
requested review from
patkenneally,
pcrosemurgy,
mattdailis,
goetzrrGit,
adrienmaillard,
camargo and
JoelCourtney
as code owners
|
This will require a bunch of changes in the aerie-ui as well. Please do not merge until we have a PR for those since it will break the UI. |
goetzrrGit
approved these changes
Aug 17, 2022
dyst5422
force-pushed
the
refactor/activity-table-rename-to-activity-directive
branch
from
f47c3d8 to
beaf2b8
Compare
dyst5422
force-pushed
the
refactor/activity-table-rename-to-activity-directive
branch
from
beaf2b8 to
fa07081
Compare
camargo
approved these changes
Aug 22, 2022
dyst5422
deleted the
refactor/activity-table-rename-to-activity-directive
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A lot of cmd-shift-f to find all the replacement locations, then iteratively going through and finding missed sports until the tests were all green again.
If you think you work with a part/path of the code that isn't currently a part of one of the e2e tests, speak up so we don't end up accidentally missing a necessary refactor.
Verification
Tests supported refactor
Documentation
Future work