Fix Background Transpiler Latest Check
#1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mythicaeda
added
fix
goetzrrGit
approved these changes
Mar 18, 2024
I noticed this while I was testing the query refactor branch. I accidentally swapped 'missionID' and 'CommandID' in the Hasura call.
Mythicaeda
force-pushed
the
fix/background-transpiler-latest-check
branch
from
e38c2b6 to
98cd503
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed how the background transpiler is checking if there are any mission models or command dictionaries uploaded. Before, it would fail to notice that no models/cdicts had been uploaded, as
mission_model_aggregate/command_dictionary_aggregateis nevernull.Verification
Spun up a fresh aerie instance and saw the correct logs printed. On develop, an exception would instead be printed.
Documentation
No docs updates needed.