Skip to content

feat: add button to resize activity table columns #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 17, 2022
Merged

feat: add button to resize activity table columns #182

merged 3 commits into from
Oct 17, 2022

Conversation

duranb
Copy link
Collaborator

@duranb duranb commented Oct 13, 2022

Resolves AERIE-2126

To test:

  1. Create a plan and add some activities
  2. Go to the Activity Table view
  3. Click the "..."
  4. Click the collapse/expand icons at the top right of the menu
  5. Verify that the columns resize to fit the content of each column or resizes to fit the available surrounding space respectively

@duranb duranb temporarily deployed to test-workflow October 13, 2022 01:59 Inactive
@duranb duranb temporarily deployed to test-workflow October 13, 2022 23:19 Inactive
@duranb duranb force-pushed the feat/AERIE-2126-auto-fit-columns branch from 32b9457 to 9049cc5 Compare October 14, 2022 21:26
@duranb duranb marked this pull request as ready for review October 14, 2022 21:27
@duranb duranb requested a review from a team as a code owner October 14, 2022 21:27
@duranb duranb temporarily deployed to test-workflow October 14, 2022 21:27 Inactive
camargo
camargo approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@camargo camargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. LGTM!

@duranb duranb force-pushed the feat/AERIE-2126-auto-fit-columns branch from 9049cc5 to 3305944 Compare October 17, 2022 19:02
@duranb duranb temporarily deployed to test-workflow October 17, 2022 19:02 Inactive
@camargo camargo merged commit 3bea334 into develop Oct 17, 2022
@camargo camargo deleted the feat/AERIE-2126-auto-fit-columns branch October 17, 2022 19:13
JosephVolosin pushed a commit that referenced this pull request Aug 20, 2024
@duranb
feat: add button to resize activity table columns (#182)
b237dd6 
* Add columns resize to fill space button
* Add columns resize to fill content button
JosephVolosin pushed a commit that referenced this pull request Oct 21, 2024
@duranb @JosephVolosin
feat: add button to resize activity table columns (#182)
61833d5 
* Add columns resize to fill space button
* Add columns resize to fill content button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camargo camargo camargo approved these changes

@jeffpamer jeffpamer Awaiting requested review from jeffpamer jeffpamer is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

@AaronPlave AaronPlave Awaiting requested review from AaronPlave AaronPlave is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duranb @camargo