Skip to content

Commit

Permalink
don't use symbol for boolean test
Browse files Browse the repository at this point in the history
  • Loading branch information
@joswig
joswig committed Nov 6, 2024
1 parent 8bc3fb7 commit 8378264
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions e2e-tests/fixtures/Sequence.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -165,14 +165,14 @@ export class Sequence {
await this.page.waitForTimeout(1000);

expect(await this.linter.count()).toBe(0);
await expect(this.command).toHaveText('C FSW_CMD_0 "ON" false 1');
await expect(this.command).toHaveText('C FSW_CMD_0 "ON" "false" 1');

Check failure on line 168 in e2e-tests/fixtures/Sequence.ts

View workflow job for this annotation

GitHub Actions / e2e-test

[e2e tests] › tests/sequence.test.ts:41:3 › Sequence › Open and modify a sequence via form editor 

  1) [e2e tests] › tests/sequence.test.ts:41:3 › Sequence › Open and modify a sequence via form editor 
    Error: Timed out 5000ms waiting for expect(locator).toHaveText(expected)

    Locator: locator('.cm-activeLine').first().getByText(/C\s+FSW_CMD_0.*/)
    Expected string: "C FSW_CMD_0 \"ON\" \"false\" 1"
    Received string: "C FSW_CMD_0 \"ON\" false 1"
    Call log:
      - expect.toHaveText with timeout 5000ms
      - waiting for locator('.cm-activeLine').first().getByText(/C\s+FSW_CMD_0.*/)
      -   locator resolved to <div class="cm-activeLine cm-line">…</div>
      -   unexpected value "C FSW_CMD_0 "ON" false 1"
      -   locator resolved to <div class="cm-activeLine cm-line">…</div>
      -   unexpected value "C FSW_CMD_0 "ON" false 1"
      -   locator resolved to <div class="cm-activeLine cm-line">…</div>
      -   unexpected value "C FSW_CMD_0 "ON" false 1"
      -   locator resolved to <div class="cm-activeLine cm-line">…</div>
      -   unexpected value "C FSW_CMD_0 "ON" false 1"
      -   locator resolved to <div class="cm-activeLine cm-line">…</div>
      -   unexpected value "C FSW_CMD_0 "ON" false 1"
      -   locator resolved to <div class="cm-activeLine cm-line">…</div>
      -   unexpected value "C FSW_CMD_0 "ON" false 1"
      -   locator resolved to <div class="cm-activeLine cm-line">…</div>
      -   unexpected value "C FSW_CMD_0 "ON" false 1"
      -   locator resolved to <div class="cm-activeLine cm-line">…</div>
      -   unexpected value "C FSW_CMD_0 "ON" false 1"
      -   locator resolved to <div class="cm-activeLine cm-line">…</div>
      -   unexpected value "C FSW_CMD_0 "ON" false 1"


       at fixtures/Sequence.ts:168

      166 |
      167 |     expect(await this.linter.count()).toBe(0);
    > 168 |     await expect(this.command).toHaveText('C FSW_CMD_0 "ON" "false" 1');
          |                                ^
      169 |     await this.page
      170 |       .locator('fieldset')
      171 |       .filter({ hasText: 'enum_arg_0 ONOFF' })

        at Sequence.modifySequence (/home/runner/work/***-ui/***-ui/e2e-tests/fixtures/Sequence.ts:168:32)
        at /home/runner/work/***-ui/***-ui/e2e-tests/tests/sequence.test.ts:42:5

Check failure on line 168 in e2e-tests/fixtures/Sequence.ts

View workflow job for this annotation

GitHub Actions / e2e-test

[e2e tests] › tests/sequence.test.ts:41:3 › Sequence › Open and modify a sequence via form editor 

  1) [e2e tests] › tests/sequence.test.ts:41:3 › Sequence › Open and modify a sequence via form editor 

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    Error: Timed out 5000ms waiting for expect(locator).toHaveText(expected)

    Locator: locator('.cm-activeLine').first().getByText(/C\s+FSW_CMD_0.*/)
    Expected string: "C FSW_CMD_0 \"ON\" \"false\" 1"
    Received string: "C FSW_CMD_0 \"ON\" false 1"
    Call log:
      - expect.toHaveText with timeout 5000ms
      - waiting for locator('.cm-activeLine').first().getByText(/C\s+FSW_CMD_0.*/)
      -   locator resolved to <div class="cm-activeLine cm-line">…</div>
      -   unexpected value "C FSW_CMD_0 "ON" false 1"
      -   locator resolved to <div class="cm-activeLine cm-line">…</div>
      -   unexpected value "C FSW_CMD_0 "ON" false 1"
      -   locator resolved to <div class="cm-activeLine cm-line">…</div>
      -   unexpected value "C FSW_CMD_0 "ON" false 1"
      -   locator resolved to <div class="cm-activeLine cm-line">…</div>
      -   unexpected value "C FSW_CMD_0 "ON" false 1"
      -   locator resolved to <div class="cm-activeLine cm-line">…</div>
      -   unexpected value "C FSW_CMD_0 "ON" false 1"
      -   locator resolved to <div class="cm-activeLine cm-line">…</div>
      -   unexpected value "C FSW_CMD_0 "ON" false 1"
      -   locator resolved to <div class="cm-activeLine cm-line">…</div>
      -   unexpected value "C FSW_CMD_0 "ON" false 1"
      -   locator resolved to <div class="cm-activeLine cm-line">…</div>
      -   unexpected value "C FSW_CMD_0 "ON" false 1"
      -   locator resolved to <div class="cm-activeLine cm-line">…</div>
      -   unexpected value "C FSW_CMD_0 "ON" false 1"


       at fixtures/Sequence.ts:168

      166 |
      167 |     expect(await this.linter.count()).toBe(0);
    > 168 |     await expect(this.command).toHaveText('C FSW_CMD_0 "ON" "false" 1');
          |                                ^
      169 |     await this.page
      170 |       .locator('fieldset')
      171 |       .filter({ hasText: 'enum_arg_0 ONOFF' })

        at Sequence.modifySequence (/home/runner/work/***-ui/***-ui/e2e-tests/fixtures/Sequence.ts:168:32)
        at /home/runner/work/***-ui/***-ui/e2e-tests/tests/sequence.test.ts:42:5

Check failure on line 168 in e2e-tests/fixtures/Sequence.ts

View workflow job for this annotation

GitHub Actions / e2e-test

[e2e tests] › tests/sequence.test.ts:41:3 › Sequence › Open and modify a sequence via form editor 

  1) [e2e tests] › tests/sequence.test.ts:41:3 › Sequence › Open and modify a sequence via form editor 

    Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
    Error: Timed out 5000ms waiting for expect(locator).toHaveText(expected)

    Locator: locator('.cm-activeLine').first().getByText(/C\s+FSW_CMD_0.*/)
    Expected string: "C FSW_CMD_0 \"ON\" \"false\" 1"
    Received string: "C FSW_CMD_0 \"ON\" false 1"
    Call log:
      - expect.toHaveText with timeout 5000ms
      - waiting for locator('.cm-activeLine').first().getByText(/C\s+FSW_CMD_0.*/)
      -   locator resolved to <div class="cm-activeLine cm-line">…</div>
      -   unexpected value "C FSW_CMD_0 "ON" false 1"
      -   locator resolved to <div class="cm-activeLine cm-line">…</div>
      -   unexpected value "C FSW_CMD_0 "ON" false 1"
      -   locator resolved to <div class="cm-activeLine cm-line">…</div>
      -   unexpected value "C FSW_CMD_0 "ON" false 1"
      -   locator resolved to <div class="cm-activeLine cm-line">…</div>
      -   unexpected value "C FSW_CMD_0 "ON" false 1"
      -   locator resolved to <div class="cm-activeLine cm-line">…</div>
      -   unexpected value "C FSW_CMD_0 "ON" false 1"
      -   locator resolved to <div class="cm-activeLine cm-line">…</div>
      -   unexpected value "C FSW_CMD_0 "ON" false 1"
      -   locator resolved to <div class="cm-activeLine cm-line">…</div>
      -   unexpected value "C FSW_CMD_0 "ON" false 1"
      -   locator resolved to <div class="cm-activeLine cm-line">…</div>
      -   unexpected value "C FSW_CMD_0 "ON" false 1"
      -   locator resolved to <div class="cm-activeLine cm-line">…</div>
      -   unexpected value "C FSW_CMD_0 "ON" false 1"


       at fixtures/Sequence.ts:168

      166 |
      167 |     expect(await this.linter.count()).toBe(0);
    > 168 |     await expect(this.command).toHaveText('C FSW_CMD_0 "ON" "false" 1');
          |                                ^
      169 |     await this.page
      170 |       .locator('fieldset')
      171 |       .filter({ hasText: 'enum_arg_0 ONOFF' })

        at Sequence.modifySequence (/home/runner/work/***-ui/***-ui/e2e-tests/fixtures/Sequence.ts:168:32)
        at /home/runner/work/***-ui/***-ui/e2e-tests/tests/sequence.test.ts:42:5
await this.page
.locator('fieldset')
.filter({ hasText: 'enum_arg_0 ONOFF' })
.getByRole('combobox')
.selectOption('OFF');

await expect(this.command).toHaveText('C FSW_CMD_0 "OFF" false 1');
await expect(this.command).toHaveText('C FSW_CMD_0 "OFF" "false" 1');

await this.page.getByRole('button', { name: 'Save' }).click();
await this.page.getByRole('button', { name: 'Close' }).click();
Expand Down

0 comments on commit 8378264

Please sign in to comment.