-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
152 migrate to pydantic v2 #167
Conversation
…ore' into 152-migrate-to-pydantic-v2 # Conflicts: # app/Entirety/requirements.txt
… 152-migrate-to-pydantic-v2 # Conflicts: # app/Entirety/entirety/settings.py
@sbanoeon could you have a look at the settings for Loki? I think it has to be restructured |
The JsonSchemaParser we have using now is also migrated to Pydantic V2. We need to check the implementation of the Normalized Parser, and implement a keyValue parser to enable our need. https://jugit.fz-juelich.de/iek-10/public/ict-platform/fiware-applications/jsonschemaparser/-/blob/master/examples/normalized/normalized_form.py?ref_type=heads |
@djs0109 I have adapted the changes according to new json schema parser model. Can you please have a look at it? |
@sbanoeon could you try to update the dependency of filip to 0.5.0? |
Just to keep a track, this is the list of forbidden characters for Fiware Orion requests https://fiware-orion.readthedocs.io/en/master/orion-api.html#general-syntax-restrictions. This is the reason we need to handle the default value for some attribute values where there are special characters which are forbidden for Fiware Orion request. |
Due this issue # 1626 in datamodel-code-generator, the camel case json schema cannot be parsed right now |
@sbanoeon now it looks good to me. I have changed the pip commands in docker file and add a hint in readme, so that the jsonschemaparser will no more in the requirments.txt. Besides, I fix some errors due to the migration. If it also looks good to you, we can merge :) thanks! |
closes #152