Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

152 migrate to pydantic v2 #167

Merged
merged 29 commits into from
Oct 10, 2024
Merged

152 migrate to pydantic v2 #167

merged 29 commits into from
Oct 10, 2024

Conversation

djs0109
Copy link
Collaborator

@djs0109 djs0109 commented Mar 6, 2024

closes #152

@djs0109 djs0109 linked an issue Mar 6, 2024 that may be closed by this pull request
@djs0109
Copy link
Collaborator Author

djs0109 commented Mar 6, 2024

@sbanoeon could you have a look at the settings for Loki? I think it has to be restructured

@djs0109
Copy link
Collaborator Author

djs0109 commented Jul 10, 2024

The JsonSchemaParser we have using now is also migrated to Pydantic V2. We need to check the implementation of the Normalized Parser, and implement a keyValue parser to enable our need. https://jugit.fz-juelich.de/iek-10/public/ict-platform/fiware-applications/jsonschemaparser/-/blob/master/examples/normalized/normalized_form.py?ref_type=heads

@sbanoeon
Copy link
Contributor

@djs0109 I have adapted the changes according to new json schema parser model. Can you please have a look at it?

@djs0109
Copy link
Collaborator Author

djs0109 commented Sep 18, 2024

@sbanoeon could you try to update the dependency of filip to 0.5.0?

@sbanoeon
Copy link
Contributor

Just to keep a track, this is the list of forbidden characters for Fiware Orion requests https://fiware-orion.readthedocs.io/en/master/orion-api.html#general-syntax-restrictions. This is the reason we need to handle the default value for some attribute values where there are special characters which are forbidden for Fiware Orion request.

@djs0109
Copy link
Collaborator Author

djs0109 commented Oct 2, 2024

Due this issue # 1626 in datamodel-code-generator, the camel case json schema cannot be parsed right now

@djs0109
Copy link
Collaborator Author

djs0109 commented Oct 9, 2024

@sbanoeon now it looks good to me. I have changed the pip commands in docker file and add a hint in readme, so that the jsonschemaparser will no more in the requirments.txt. Besides, I fix some errors due to the migration. If it also looks good to you, we can merge :) thanks!

@sbanoeon sbanoeon self-requested a review October 10, 2024 11:31
@sbanoeon sbanoeon merged commit 90552b3 into development Oct 10, 2024
@djs0109 djs0109 deleted the 152-migrate-to-pydantic-v2 branch January 15, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to pydantic V2
2 participants