Gateway error handling: add a handler for 404 status code and fix the…

… 400 status code message Fixes rucio#313
MytsV · Aug 15, 2024 · c103314 · c103314
1 parent a03e562
commit c103314
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/src/lib/sdk/gateway-endpoints.ts b/src/lib/sdk/gateway-endpoints.ts
@@ -268,11 +268,10 @@ async function handleCommonGatewayEndpointErrors<TDTO extends BaseDTO>(statusCod
         errorMessage: `An error occurred while fetching ${response.url}`,
     } as TDTO;
 
-
     switch(statusCode) {
         case 400:
-            dto.errorName = BaseHttpErrorTypes.NOT_FOUND.errorName;
-            dto.errorMessage = `The requested resource was not found at ${response.url}.`
+            dto.errorName = BaseHttpErrorTypes.BAD_REQUEST.errorName;
+            dto.errorMessage = `The request had invalid syntax.`
             try {
                 const message = await response.json();
                 dto.errorMessage += ` Error Details: ${message}`; 
@@ -286,6 +285,14 @@ async function handleCommonGatewayEndpointErrors<TDTO extends BaseDTO>(statusCod
                 dto.errorMessage += ` Error Details: ${message}`; 
             } catch(error) {}
             break;
+        case 404:
+            dto.errorName = BaseHttpErrorTypes.NOT_FOUND.errorName;
+            dto.errorMessage = `The requested resource was not found at ${response.url}.`
+            try {
+                const message = await response.json();
+                dto.errorMessage += ` Error Details: ${message}`;
+            } catch(error) {}
+            break;
         case 406:
             dto.errorName = BaseHttpErrorTypes.NOT_ACCEPTABLE.errorName;
             dto.errorMessage = `Not Acceptable.`;