Miscellaneous refactoring #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes an else case when creating the output payload path for reading to handle a build parameter output type that is unknown. This should never happen since the build parameters are set above but this satisfies a pylint error where the `payload_path` variable may be undefined.
Removes the conditional compilation `cfg(http)` flag for selecting the http profile. This should be added back as a feature flag instead of a Rust cfg flag when multiple profiles are supported.
Adds underscore prefixes to unused variables for to silence unused variable warnings.
Adds error handling for reading the SELinux config in cases where the file gets corrupted while it is being read.
Changes comment in src/netstat.rs return statement to an inline comment instead of a doc comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project refactoring to remove lint and compile warnings.
Changes
cfgdirective for profile conditional compilation.getprivscommand.