Support playing Audio CD from optical disc menu #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hambre
force-pushed
the
hambre/play-audio-cd-from-menu
branch
from
cff4fc0 to
84d35e8
Compare
hambre
changed the title
hambre
changed the title
hambre
force-pushed
the
hambre/play-audio-cd-from-menu
branch
2 times, most recently
from
dff4d1d to
f10251a
Compare
hambre
force-pushed
the
hambre/play-audio-cd-from-menu
branch
2 times, most recently
from
150ee6e to
f0acb3b
Compare
hambre
force-pushed
the
hambre/play-audio-cd-from-menu
branch
from
b972e76 to
8f775c3
Compare
Add support to play an audio CD from the 'Play Optical Disc' menu. The media monitor callback function was extended by a 'forcePlayback' parameter which will override the auto play option for some of the media handlers when started explicitly by the user via the menu.
hambre
force-pushed
the
hambre/play-audio-cd-from-menu
branch
from
8f775c3 to
3a6c57e
Compare
|
This works when the media monitor is running, but I can no longer play DVDs when the media monitor isn't running. |
Thanks for giving it a try. I will take a look and try to fix the issue. |
|
@linuxdude42 , I fixed DVD playback when media monitor is not running. Could you have another look, please? |
Convert an old style "typedef" statement into a modern "using" statement. Change made by clang-tidy. https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-using.html
|
Great, thanks for merging it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to play an audio CD from the 'Play Optical Disc' menu. The media monitor callback function was extended by a 'forcePlayback' parameter which will override the auto play option for some of the media handlers when started explicitly by the user via the menu.