remove unused pidfile and logfile global variables #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulmus-scott
force-pushed
the
pidfile
branch
2 times, most recently
from
6a5eb9e to
56246ec
Compare
Only mythbackend deletes the pidfile it creates. MythCommandLineParser says --logfile was removed in version 0.25.
It is created first by the call to MythCommandLineParser::Daemonize() which calls openPidfile(). This also makes the other programs delete the pidfile as seems to have been the intention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also improve code creating and deleting the pidfile for mythbackend.
Expanded version of a commit from #671.
Checklist