Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DaraGrid breaks when item property inside has been changed #3

Closed
Myszax opened this issue Jul 18, 2023 · 1 comment · Fixed by #4
Closed

DaraGrid breaks when item property inside has been changed #3

Myszax opened this issue Jul 18, 2023 · 1 comment · Fixed by #4
Assignees
Labels
bug Something isn't working

Comments

@Myszax
Copy link
Owner

Myszax commented Jul 18, 2023

When Conversation object has been changed inside DataGrid_Upper or DataGrid_Lower item selection is broken.
For example when I click Inspected on DataGrid then I cannot select other item/play sound of other item.
Everything back to normal when I uncheck box and revert the state of this item.
Same applies when I edit text of some item.

@Myszax Myszax added the bug Something isn't working label Jul 18, 2023
@Myszax Myszax self-assigned this Jul 18, 2023
@Myszax
Copy link
Owner Author

Myszax commented Jul 19, 2023

I have found that public override int GetHashCode() in Conversation causing this problem or rather implementation IEquatable.
To be more precise GetHashCode() shouldn't be implemented on mutable (editable) fields/properties.

@Myszax Myszax closed this as completed Jul 19, 2023
@Myszax Myszax linked a pull request Jul 19, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant