[checkpoint] Log the size of checkpoint fragment message #4641
Conversation
lxfind
requested review from
asonnino,
gdanezis,
longbowlu,
andll,
velvia and
mystenmark
| debug!( | ||
| ?tracking_id, | ||
| ?cp_seq, | ||
| size=?serialized.len(), | ||
| "Checkpoint fragment consensus message created. Proposer: {}, Other: {}", | ||
| proposer, |
There was a problem hiding this comment.
These could be put into fields too.
There was a problem hiding this comment.
Sorry I mean that you could move proposer and the Other field up before the text so they are key=value pairs as well.... instead of using Proposer: {} Other: {}
There was a problem hiding this comment.
Oh they are different though. With {} it will trigger the Display implementation. While putting in the fields would be equivalent to {:?} which is not desired in this case.
There was a problem hiding this comment.
It's not true that fields is equivalent to {:?}. That is true only if you put ?var or key =? var... if you do just var or key=var then it uses Display or Value. However if it is Value then one has to implement Value for our types which is a bit of a pain I guess.
We can tell how big a fragment typically gets.