-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[explorer] Remove targeted builds for explorer #4631
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a suggested update to strings as I am not able to add a commit.
``` | ||
|
||
Then, click the green button at the top and select the option 'Custom RPC URL'. Type the Custom RPC URL into the input box that emerges. | ||
If you want to use the explorer with another network, you can select your preferred network in the header of the explorer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't they need to choose Custom RPC URL and then enter the IP address to the server?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For custom fullnodes, yes.
Co-authored-by: Randall-Mysten <109545725+randall-Mysten@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
This removes the targeted builds for explorer, and instead infers the network information from the URL. The goal of this is to simplify the build and deploy process of the explorer.
As part of this change, the default network for local development has changed to localnet. In general, I think this is a good default, and can still be overridden in the UI easily. This can also be overridden via the
VITE_NETWORK
environment variable, and therpcUrl
query parameter. If you primarily develop against devnet, you should be able to just set the network once, and the localStorage preference should keep it set for you.