[adapter] Pass write kind information to temporary store #4552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tnowacki
commented
Sep 10, 2022
tnowacki
commented
- The temporary storage and Storage trait has to recreate a lot of information already known to the adapter
- This removes some messiness about having to determine what objects were created or wrapped, which is already done inside the adapter
tnowacki
requested review from
lxfind,
awelc,
sblackshear,
gdanezis,
bmwill,
damirka,
emmazzz and
oxade
bmwill
approved these changes
Sep 12, 2022
lxfind
reviewed
Sep 12, 2022
| @@ -1423,11 +1423,16 @@ impl TransactionEffects { | |||
| /// created and unwrapped objects. In other words, all objects that still exist | |||
| /// in the object state after this transaction. | |||
| /// It doesn't include deleted/wrapped objects. | |||
| pub fn all_mutated(&self) -> impl Iterator<Item = &(ObjectRef, Owner)> + Clone { | |||
| pub fn all_mutated(&self) -> impl Iterator<Item = (&ObjectRef, &Owner, WriteKind)> + Clone { | |||
There was a problem hiding this comment.
Does this function need to return the WriteKind?
There was a problem hiding this comment.
Yes, because of gateway_state. It pulls information out of transaction effects, modifies it, and puts it back into a new TemporaryStore, which now needs the write kind
tnowacki
force-pushed
the
create
branch
2 times, most recently
from
d4260ec
to
c2e39f6
Compare
- The temporary storage and Storage trait has to recreate a lot of information already known to the adapter - This removes some messiness about having to determine what objects were created or wrapped, which is already done inside the adapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.