[reconfig] Allow sync last checkpoint tx when validator is halted #4493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxfind
force-pushed
the
reconfig-add-special-checkpoint-sync-halt
branch
from
a0ac21a
to
483f736
Compare
lxfind
force-pushed
the
reconfig-add-special-checkpoint-sync-halt
branch
from
483f736
to
cd28fa1
Compare
lxfind
force-pushed
the
reconfig-add-special-checkpoint-sync-halt
branch
from
cd28fa1
to
d028cc7
Compare
mystenmark
approved these changes
Sep 26, 2022
lxfind
force-pushed
the
reconfig-add-special-checkpoint-sync-halt
branch
from
d028cc7
to
9654a7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During reconfiguration, when the validators are halted, if we find out that we are missing some transactions from the last checkpoint, we need to be able to execute them. This PR adds a path that allows us to execute transactions even when the validator is halted, if we know for sure that the transaction has been finalized.
The code is becoming a bit messy and hard to reason about. I have some ideas to clean this up but would love to get feedback first. One way to make this easier to reason about is to define a ProofOfFinality struct, and then pass it into process certificate. This will at least allow us easily find out where the proof came from.