Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More cost snapshot tests #4449

Merged
merged 4 commits into from
Sep 2, 2022
Merged

More cost snapshot tests #4449

merged 4 commits into from
Sep 2, 2022

Conversation

oxade
Copy link
Contributor

@oxade oxade commented Sep 2, 2022

This PR is NFC but will help detect issues.
This PR cleans up snapshots and adds snapshots to our calibration logic.
These new snapshots are used to ensure that the base logic we use to calibrate costs do not change without our knowledge.

@oxade oxade requested review from awelc and emmazzz September 2, 2022 14:20
@oxade oxade enabled auto-merge (squash) September 2, 2022 14:45
Copy link
Contributor

@gegaowp gegaowp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good move!

@oxade oxade merged commit ed4258a into main Sep 2, 2022
@oxade oxade deleted the more_cost_snapshot_tests branch September 2, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants