Explorer transfer table1 #3101
Merged
Explorer transfer table1 #3101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stella3d
suggested changes
Jul 8, 2022
There was a problem hiding this comment.
looks mostly good, i feel like this bundles together a few parts which should come separately.
We could really use this table view as a re-usable component for other kinds of data. I would like it if we can break that out of the part of this PR that relies on mock data we don't have ready yet - would make it easier to review.
|
Remove component with mock data from the home page and added the old pagination. Pending design update. |
666lcz
reviewed
Jul 8, 2022
| categoryName: 'transactions' as Category, | ||
| isLink: true, | ||
| isCopyButton: false, | ||
| alttext: 'More Transaction', |
There was a problem hiding this comment.
Suggested change
| alttext: 'More Transaction', | |
| alttext: 'More Transactions', |
666lcz
approved these changes
Jul 11, 2022
stella3d
approved these changes
Jul 11, 2022
|
@stella3d thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2022-07-07.at.5.48.15.PM.mov