Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update h2 to 0.3.24 #15762

Merged
merged 1 commit into from
Jan 17, 2024
Merged

update h2 to 0.3.24 #15762

merged 1 commit into from
Jan 17, 2024

Conversation

longbowlu
Copy link
Collaborator

Description

cargo deny check advisories
error[vulnerability]: Resource exhaustion vulnerability in h2 may lead to Denial of Service (DoS)
    ┌─ /Users/luzhang/Workplaces/sui/Cargo.lock:415:1
    │
415 │ h2 0.3.18 registry+https://github.com/rust-lang/crates.io-index
    │ --------------------------------------------------------------- security vulnerability detected
    │
    = ID: RUSTSEC-2024-0003
    = Advisory: https://rustsec.org/advisories/RUSTSEC-2024-0003
    = An attacker with an HTTP/2 connection to an affected endpoint can send a steady stream of invalid frames to force the
      generation of reset frames on the victim endpoint.
      By closing their recv window, the attacker could then force these resets to be queued in an unbounded fashion,
      resulting in Out Of Memory (OOM) and high CPU usage.

      This fix is corrected in [hyperium/h2#737](https://github.com/hyperium/h2/pull/737), which limits the total number of
      internal error resets emitted by default before the connection is closed.
    = Solution: Upgrade to ^0.3.24 OR >=0.4.2 (try `cargo update -p h2`)
    = h2 v0.3.18

Test Plan

cargo deny check advisories


If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section.

Type of Change (Check all that apply)

  • protocol change
  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

Copy link

vercel bot commented Jan 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mysten-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2024 11:45pm
sui-core ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2024 11:45pm
sui-typescript-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2024 11:45pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Jan 17, 2024 11:45pm
multisig-toolkit ⬜️ Ignored (Inspect) Jan 17, 2024 11:45pm
sui-kiosk ⬜️ Ignored (Inspect) Jan 17, 2024 11:45pm

@longbowlu longbowlu merged commit 67cfca8 into main Jan 17, 2024
44 checks passed
@longbowlu longbowlu deleted the upgrade-h2-for-advisories branch January 17, 2024 23:55
wlmyng pushed a commit that referenced this pull request Jan 19, 2024
## Description 

```
cargo deny check advisories
error[vulnerability]: Resource exhaustion vulnerability in h2 may lead to Denial of Service (DoS)
    ┌─ /Users/luzhang/Workplaces/sui/Cargo.lock:415:1
    │
415 │ h2 0.3.18 registry+https://github.com/rust-lang/crates.io-index
    │ --------------------------------------------------------------- security vulnerability detected
    │
    = ID: RUSTSEC-2024-0003
    = Advisory: https://rustsec.org/advisories/RUSTSEC-2024-0003
    = An attacker with an HTTP/2 connection to an affected endpoint can send a steady stream of invalid frames to force the
      generation of reset frames on the victim endpoint.
      By closing their recv window, the attacker could then force these resets to be queued in an unbounded fashion,
      resulting in Out Of Memory (OOM) and high CPU usage.

      This fix is corrected in [hyperium/h2#737](hyperium/h2#737), which limits the total number of
      internal error resets emitted by default before the connection is closed.
    = Solution: Upgrade to ^0.3.24 OR >=0.4.2 (try `cargo update -p h2`)
    = h2 v0.3.18

```

## Test Plan 

cargo deny check advisories


---
If your changes are not user-facing and do not break anything, you can
skip the following section. Otherwise, please briefly describe what has
changed under the Release Notes section.

### Type of Change (Check all that apply)

- [ ] protocol change
- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration

### Release notes
@awelc awelc mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants