[move 2024] let mut #14184
Merged
[move 2024] let mut #14184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
cgswords
reviewed
Oct 11, 2023
cgswords
reviewed
Oct 11, 2023
cgswords
requested changes
Oct 11, 2023
7 tasks
cgswords
reviewed
Oct 12, 2023
Comment on lines
+2573
to
+2575
| let supports_let_mut = context | ||
| .env | ||
| .supports_feature(context.current_package, FeatureGate::LetMut); |
cgswords
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
mutmodifier on variable declarations is not required for Move 2024mutmodifiers are reportedS { mut f }punning for variable declarations with unpackTest Plan
If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes
Move 2024.alpha now requires
muton local variables that are assigned or borrowed mutably. This is done on local variable declarations, e.g.let mut x = 0. And can also be done when field punning, e.g.let S { mut f } = s;