[move 2024][alpha] Method syntax #13933
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
tnowacki
requested review from
amnn,
cgswords,
awelc,
tzakian,
sblackshear and
dariorussi
| @@ -250,6 +251,7 @@ codes!( | |||
| (NOTE: this may become an error in the future)", | |||
| severity: Warning | |||
| }, | |||
| InvalidMethodCall: { msg: "invalid method style call", severity: BlockingError }, | |||
There was a problem hiding this comment.
Definitely prefer this over "invalid method call" and I think this conveys that this isn't an actual method call. One other option might be "invalid method-style function call" the addition of function helps disambiguate that this isn't an actual method you're calling I think.
There was a problem hiding this comment.
🚲 "invalid method-style invocation"
| @@ -227,6 +247,7 @@ pub fn program( | |||
| keyed | |||
| }; | |||
|
|
|||
| super::primitive_definers::determine(context.env, pre_compiled_lib, &module_map); | |||
There was a problem hiding this comment.
Not a gigantic name of determine for this function since this validates them as opposed to determining them. Thoughts something more like validate?
There was a problem hiding this comment.
I shall give it an even more cryptic name! (Seriously I think modules is more in line with the rest of the compiler, but I'll add a comment)
tnowacki
changed the title
| 2 │ fun foo<T>(x: T) { | ||
| │ - But 'T' was declared as a type parameter here | ||
| 3 │ use fun foo as T.foo; | ||
| │ ^^^^^^^^^^^^^^^^^^^^^ Invalid 'use fun'. Cannot associate a function as a method a type parameter |
There was a problem hiding this comment.
This error message is a little wonky
Description
See 'Release Notes' for feature description.
This PR:
defines_primitiveannotation so that method style syntax can be used with primitive/builtin typesSome notes about implementation details
use a::m::f as gintroduces an implicituse fun a::m::f as a::m::S.gin situations where the first argument ofa::m::fisa::m::S. This ensures that there isn't any weird precedence/shadowing betweenuseanduse funin a given scope.x.foo(), it always resolves to the same functiona::m::bar, even if newpublic use funs are added elsewhere.ProgramInfointo thenaming::ast::programandtyping::ast::programto properly resolveuse funs(particularly with this implicit setup described above)TODO:
Follow up
let mutandmutvariable modifiersTest Plan
How did you test the new or updated feature?
If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes
Method style syntax has been added to Move 2024.alpha. This means functions can now be invoked with the syntax,
e.foo(arg1, arg2). Assuminge: a::m::S(or&a::m::Sor&mut a::m::S),e.foo(arg1, arg2)will resolve toa::m::foo(e, arg1, arg2). Additionally, the compiler will borrowewhen necessary.For instances where the desired target function is not declared in the same module as the type (or is not declared with the desired name), a
use funalias can be used instead. For example,use b::n::bar as S.bazwill allowe.baz()to resolve asb::n::bar(e). Apublic use funcan be declared in the types defining module, allowing the alias to be used outside of the module.