[move-compiler][sui-mode] Add entry function signature checks #12990
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Ignored Deployments
|
| fn tx_context_kind(sp!(_, last_param_ty_): &Type) -> TxContextKind { | ||
| let (is_mut, inner_ty) = match last_param_ty_ { | ||
| Type_::Ref(is_mut, inner_ty) => (*is_mut, &inner_ty.value), | ||
| _ => return TxContextKind::None, |
There was a problem hiding this comment.
At this point do we already detect and error on a TxContext by value?
There was a problem hiding this comment.
Ah, yeah it could be an interesting warning/error?
But nothing needed at the bytecode level, so this is sort of new for source language.
| let inner_name = match inner_ty { | ||
| Type_::Apply(_, sp!(_, n_), _) => n_, | ||
| _ => return TxContextKind::None, | ||
| }; |
There was a problem hiding this comment.
In fact, would it be crazy to do this all in one let ... else?
let (is_mut, Type_::Apply(_, sp!(_, n_), _) = last_param_ty_ else {
return TxContextKind::None
}(Also, what's with the trailing underscores?)
There was a problem hiding this comment.
A naming pattern I use around the compiler for Spanned<T> items, where I will normally do n @ sp!(loc, n_). Which (for better or for worse) is a pattern I've held onto from OCaml
There was a problem hiding this comment.
And I cannot do 1 let-else because of the Box 💢
There was a problem hiding this comment.
As I said it, I knew this was why, I just hoped I was wrong...
| } | ||
| } | ||
|
|
||
| fn entry_return( |
There was a problem hiding this comment.
Can we document or link to the documentation for what we expect from a valid entry return type? (TIL we can return drop-able types from an entry functions).
There was a problem hiding this comment.
I can do it as a separate PR, sure!
- Ported entry function signature checks to the compiler guarded by sui-mode
github-actions
bot
added
the
Type: Documentation
Description
Test Plan
If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes
The Sui Move toolchain will now provide diagnostics (in the form of errors) for incorrect
entryfunction signatures at the source language level.