Update based on Tim's feedback.

MystenLabs · Aug 23, 2023 · 88563a5 · 88563a5
1 parent 7f8441c
commit 88563a5
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/external-crates/move/move-compiler/src/parser/syntax.rs b/external-crates/move/move-compiler/src/parser/syntax.rs
@@ -523,9 +523,9 @@ fn parse_visibility(context: &mut Context) -> Result<Visibility, Box<Diagnostic>
         _ => {
             let msg = format!(
                 "Invalid visibility modifier. Consider removing it or using '{}', '{}' or '{}'",
+                Visibility::PUBLIC,
                 Visibility::FRIEND,
                 Visibility::PACKAGE,
-                Visibility::SCRIPT,
             );
             return Err(Box::new(diag!(Syntax::UnexpectedToken, (loc, msg))));
         }

diff --git a/external-crates/move/move-compiler/tests/move_check/parser/function_visibility_empty.exp b/external-crates/move/move-compiler/tests/move_check/parser/function_visibility_empty.exp
@@ -2,5 +2,5 @@ error[E01002]: unexpected token
   ┌─ tests/move_check/parser/function_visibility_empty.move:2:5
   │
 2 │     public() fun f() {}
-  │     ^^^^^^^^ Invalid visibility modifier. Consider removing it or using 'public(friend)', 'public(package)' or 'public(script)'
+  │     ^^^^^^^^ Invalid visibility modifier. Consider removing it or using 'public', 'public(friend)' or 'public(package)'
 
diff --git a/external-crates/move/move-compiler/tests/move_check/parser/function_visibility_invalid.exp b/external-crates/move/move-compiler/tests/move_check/parser/function_visibility_invalid.exp
@@ -2,5 +2,5 @@ error[E01002]: unexpected token
   ┌─ tests/move_check/parser/function_visibility_invalid.move:2:5
   │
 2 │     public(invalid_modifier) fun f() {}
-  │     ^^^^^^^^^^^^^^^^^^^^^^^^ Invalid visibility modifier. Consider removing it or using 'public(friend)', 'public(package)' or 'public(script)'
+  │     ^^^^^^^^^^^^^^^^^^^^^^^^ Invalid visibility modifier. Consider removing it or using 'public', 'public(friend)' or 'public(package)'
 
diff --git a/...l-crates/move/move-compiler/tests/move_check/typing/module_public_package_featuregate.exp b/...l-crates/move/move-compiler/tests/move_check/typing/module_public_package_featuregate.exp
@@ -2,7 +2,7 @@ error[E13001]: feature is not supported in specified edition
   ┌─ tests/move_check/typing/module_public_package_featuregate.move:2:5
   │
 2 │     public(package) fun foo(): u64 { 0 }
-  │     ^^^^^^^^^^^^^^^  not supported by current edition 'legacy', only '2024.alpha'
+  │     ^^^^^^^^^^^^^^^  not supported by current edition 'legacy', only '2024.alpha' support this feature
   │
   = You can update the edition in the 'Move.toml', or via command line flag if invoking the compiler directly.