Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sending missing context field on main messagebus #100

Merged
merged 1 commit into from
Sep 6, 2021

Conversation

AIIX
Copy link
Collaborator

@AIIX AIIX commented Sep 6, 2021

Context fields were previously ignored from being sent as they weren't previously useful but have always been part of the messagebus message format

  • Hivemind makes use of the context message to route incoming messages to Mycroft core in the mesh network by adding source and destination fields
  • This PR adds the sending of context messages only if hivemind protocol is enabled in the Global Settings as too safeguard all other implementations using the sendRequest and sendBinary functions from Mycroft Connect
  • Context messages are by default set to as empty when not used
  • Only sendText function utilized by the text field in the Mycroft GUI application sends the context fields in the message currently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants